Use ">>" in place of "-" between package index ID components #210
+57
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since package index data occurs in arrays, the rules must indicate to the user the specific element(s) in violation. In the case of standard components (e.g. platform), the form of the IDs is well established (e.g., `arduino:[email protected]`). However, that I know of, there is no standard form for unequivocally identifying a package index data subcomponent (e.g., a tool dependency of a specific platform release). I arbitrarily chose a dash to combine the IDs of the two components (e.g., `arduino:[email protected] - x86_64-linux-gnu`). I received feedback that this was not very clear, with a suggestion to use ">>" instead of the "-" (e.g., `arduino:[email protected] >> x86_64-linux-gnu`).
per1234
added
type: enhancement
Codecov Report
@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 87.93% 87.96% +0.02%
==========================================
Files 43 43
Lines 4160 4170 +10
==========================================
+ Hits 3658 3668 +10
Misses 391 391
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
umbynos
approved these changes
Jul 21, 2021
silvanocerza
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since package index data occurs in arrays, the rules must indicate to the user the specific element(s) in violation. In the case of standard components (e.g. platform), the form of the IDs is well established (e.g.,
arduino:[email protected]). However, that I know of, there is no standard form for unequivocally identifying a package index data subcomponent (e.g., a tool dependency of a specific platform release).I arbitrarily chose a dash to combine the IDs of the two components (e.g.,
arduino:[email protected] - x86_64-linux-gnu). I received feedback that this was not very clear, with a suggestion to use ">>" instead of the "-" (e.g.,arduino:[email protected] >> x86_64-linux-gnu).